Maximum

[iker_13]

Whats wrong with this code? And what should I do?

#include<stdio.h>
int main()
{
    int i,n, lar, elem;
    printf("Enter total number of elements\n");
    scanf("%d",&elem);
    printf("Enter first number\n");
    scanf("%d",&n);
    lar=n;
    for(i=1; i<=elem -1;i++);
    {
        printf("n\ Enter the number \n");
        scanf("%d",&n);
        if(n>lar)
        lar=n;
    }
    printf("n\ The largest number is %d",lar);
    return 0;
}

[touhidurrr]

You have already been answered @iker_13 .
Read this.

[iker_13]

What are the things should I keep in mind to solve this problem?
This is by far the hardest one I have faced.
Suggestions please…

[iker_13]

Is this code even right/correct?

#include<stdio.h>
int main()

{
    int n,i, lar;
    scanf("%d%d",&n,&i);
    for(i<1;i=1;i++);
    if(n>lar)
        n=lar;
    {
        printf("%d",lar);
    }

    return 0;
}

Toph shows CPU limit exceeded

[hjr265]

@iker_13 Here are some pointers based on your previous code that you shared here:

1. Do not print anything other than the answer. No “Enter total number of elements\n”, no extra texts.

2. First take an input n. Then a loop should run n times and read n numbers. And every time you get the number, compare it with the largest one and see if the new number that you read is the largest one.

3. Print just the largest number at the end as printf("%d\n", largest);. Do not print anything else.

[hjr265]

@iker_13

scanf(“%d%d”,&n,&i);

You should only read the value of n here.

Next, fix the the loop: it should start with i = 0 and run while i < n.

Inside the loop, scanf a number and compare it with your current largest. This will then run n times inside the loop.

[salwamehreen]

#include<stdio.h>
int main()
{
    int i,num[99],n;
    scanf("%d",&n);

    for(i=0;i<n;i++)
    {
        scanf("%d",&num[n]);
    }
    int max=num[0];
    for(i=1;i<n;i++)
    {
        if (max<num[i]);
        max=num[i];
    }
    printf("%d\n",num[i]);
    return 0;




}

whats wrong in here?

[hjr265]

Looks like you figured it out already.

It’s amazing how much an extra semicolon can mess up.

[tania.238473]

numbers=list(map(int,input().split()))
print(max(numbers))

what was the problem??it return output on my editor correctly but when i submit the code they say wrong answer

[hjr265]

@tania.238473 The statement says:

The first line of the input will contain N

Here N is the number of integers that you will have read from the next line and see which one is the maximum among them.

Your code is reading just N (from the first line), and not the actual N numbers (from the second line) that you need to compare.

[SonicTitan03]

#include<stdio.h>
int main()
{
int a,b,c,d;
scanf(“%d\n”,d);
scanf(“%d %d %d”,&a,&b,&c);
if(a>b && a>c ){
printf(“%d”,a);
}
else if(b>a && b>c){
printf(“%d”,b);
}
else if(c>b && c>a){
printf(“%d”,c);
}
}

what is my problem

[BlueBeard]

#include <stdio.h>

int main()
{
unsigned int G,N,max=1,final;
int b;
scanf(“%d”,&N);
for(b=1;b<=N;b++)
{
scanf(“%d”,&G);
if(max>G)
final=max;
else
final=G;
}
printf(“%d”,final);
return 0;
}

works just fine…but it’s still showing error…a little help please??

[touhidurrr]

@SonicTitan03
What will happen if A == B == C ?
Your code will not show any output.
Try how can you fix this.

And there can be more or less than 3 numbers in the input.

[touhidurrr]

you are using unsigned int but printing int.
This might be the reason.

[BlueBeard]

turns out I was actually writing the code wrong…whereas I should have written this…

#include <stdio.h>

int main()
{
unsigned int b,G,N,max=1;
scanf(“%u\n”,&N);
for(b=1;b<=N;b++)
{
scanf(“%u”,&G);
if(max>G)
max=max;
else
max=G;
}
printf(“%u”,max);
return 0;
}

I was assigning max’s number to final(which was an unnecessary variable)…so when it was looping it was comparing G’s value to max=1, not final…should have noticed that earlier…& thanks for your advice also…will remember it in future…

[touhidurrr]

Initializing max = 1 is not a problem.
Cause all values are actually greater than 0,
So, 1 is the lowest value here.

However, the wrong comparison can be.

[BlueBeard]

Actually what I was saying was…for this piece of code-

if(max>G)
final=max;
else
final=G;
}
printf(“%d”,final);

my output was going like this-
input: 6
6,5,4,3,2,1
output:1
this was happening because every time G was being inputted it was being compared with 1…first it’s okay…but the 2nd time it needed to compared with 6 right?..as the first input was 6…but it wasn’t doing that…because we had assigned the previous G’s value in final whereas it was to be assigned as max’s value…that’s why at the end the output was 1 whereas it should have been 6…so as u said a freaking comparison ruined my day…

[touhidurrr]

Well, if it works now then it’s fine I think.
That’s what the community is for.
Again, Welcome to the Toph Community.

[BlueBeard]

Thanks a thousand times brother…

[SonicTitan03]

#include<stdio.h>
int main()
{
    int a,b,c,d;
	scanf("%d\n",d);
    scanf("%d %d %d",&a,&b,&c);
    if(a>b && a>c ){
        printf("%d",a);
    }
    else if(b>a && b>c){
        printf("%d",b);
    }
    else if(c>b && c>a){
        printf("%d",c);
    }
	else{
	    printf("All are equal.");	
	}
} 

problem ???